Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prefix for yarn start command, outputs pure json log entry #1353

Merged
merged 1 commit into from Jun 9, 2023

Conversation

bryce-fitzsimons
Copy link
Member

@bryce-fitzsimons bryce-fitzsimons commented Jun 9, 2023

Features and Changes

closes #1312

Logging in production inserts an extra | character which messes up JSON parsing for log entries. For yarn start, we add the --no-prefix flag to wsrun to avoid this.

Before:

back-end
 | {"level":30,"time":1686289445673,"pid":68807,"hostname":"Bryces-MacBook-Pro.local","msg":"No config.yml file. Using MongoDB instead to store data sources, metrics, and dimensions."}
 | {"level":30,"time":1686289446330,"pid":68807,"hostname":"Bryces-MacBook-Pro.local","msg":"Back-end is running at http://localhost:3100 in development mode. Press CTRL-C to stop"}

After:

{"level":30,"time":1686289413982,"pid":68750,"hostname":"Bryces-MacBook-Pro.local","msg":"No config.yml file. Using MongoDB instead to store data sources, metrics, and dimensions."}
{"level":30,"time":1686289414959,"pid":68750,"hostname":"Bryces-MacBook-Pro.local","msg":"Back-end is running at http://localhost:3100 in development mode. Press CTRL-C to stop"}
  • Closes (add link to issue here)

Dependencies

Testing

Screenshots

@bryce-fitzsimons bryce-fitzsimons merged commit d2dc8aa into main Jun 9, 2023
2 checks passed
@bryce-fitzsimons bryce-fitzsimons deleted the bryce/wsrun-no-prefix branch June 9, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Logging as pure json
2 participants