Fix when visual editor URL is relative (missing http://) #1377
Conversation
|
Your preview environment pr-1377-bttf has been deployed with errors. |
| className="btn btn-sm btn-primary" | ||
| onClick={async (e) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
Will changing to an anchor tag and removing preventDefault circumvent the checks we have implemented inside the onClick handler?
There was a problem hiding this comment.
It the user right clicks and opens in a new tab, it will bypass the extension check and tracking calls. I was mostly thinking about the experience if you are using a dev build of the chrome extension. The extension check will fail, and it would be nice if there was an easy way to bypass it without modifying code. Open to other ideas. Maybe in the extension modal we can add a small link to continue anyway?
I have a feeling I do have a bug there right now when URL is empty. Need to test this some more.
Features and Changes
Trims and prepends
http://to relative visual editor URLs in the "Open Visual Editor" button.Fixes #1376