Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reorganize data source information #1425

Merged
merged 12 commits into from Jul 7, 2023
Merged

docs: Reorganize data source information #1425

merged 12 commits into from Jul 7, 2023

Conversation

tzjames
Copy link
Collaborator

@tzjames tzjames commented Jul 3, 2023

Features and Changes

Reorganize Data Sources docs. This updates datasources page to be more in line with how we have people actually select their datasources in the UI. It adds a page for each data source and each event type. Some of the new pages are actually old ones moved from /guides. Others are copied from the old Connection Info section on the Data Sources page. The rest of the pages are just "docs coming soon" templates until we can fill them in with more info.

The main thing to review are:
The overall structure: The amount of nesting in the side panel is a bit much. The event-trackers and data warehouses currently don't have pages of their own but are just containers for organization. I was thinking of merging the two, but though making the distinction make things clearer and is worth the extra side menu depth. A possibility is to maybe create a new top level "Set Up" section, and make Data Warehouse and Event Trackers live under there - that would get rid of one level of hierarchy - the Data Source page which could continue to live under Platform.

The datasources.mdx file top two sections were rewritten borrowing from other sections below. The goal was to make it clearer and more inline with what the platform is actually showing. A thorough review of whether the language makes sense would be good.

Two new template files (they are very similar) are in the directories missing-datasource-docs.mdx and missing-event-tracker-docs.mdx. They language there might not fully resonate and I am open to alternate suggestions.

In the side menu I am calling the container "Data Warehouses" but on the datasources page and in our app we call it "Data Source Type".

Testing

Click around all links on the docs site, reading them, and seeing if they make sense.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Deploy preview for docs ready!

✅ Preview
https://docs-ld0cxshsd-growthbook.vercel.app

Built with commit a29b1b7.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@lukesonnet lukesonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will really help our customers!

Left a comment on two changes we should make to MixPanel docs as part of this reorganization. I think my comment should be blocking since this PR adds a new page that should have a deprecation warning.

docs/docs/app/data-source-types/mixpanel.mdx Outdated Show resolved Hide resolved
@tzjames tzjames changed the title Reorganize data source information docs: Reorganize data source information Jul 4, 2023
@@ -30,6 +30,7 @@ const config = {
/** @type {import('@docusaurus/preset-classic').Options} */
({
docs: {
breadcrumbs: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it wasn't so helpful before as there was just two layers, but now there is more.

Comment on lines -64 to -75
.menu__list {
.menu__link--sublist {
margin-inline-start: calc(
-1 * (var(--dropdown-icon-width) + var(--dropdown-icon-gap))
);

&::after {
opacity: 0.6;
}
}
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was copied from what we had before docusaurus. It messes up the indents of the new drop downs within drop downs. It didn't apply to any nodes before this change.


#### Predefined Schemas
## Data Source Types
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not necessarily happy with the section title. I use it because that is what we call it within our app. Perhaps "Data Warehouses" would be a better title for this and perhaps also a better label for the field within the app?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion, but I'd like us to start adopting "Metric Source" and "Experiment Assignment Source" for those respective tables in our user's data warehouses. I'm not sure whether renaming this concept helps or hurts that, to be honest. I'd lean towards changing it to Data Warehouse, but I'd want to make sure we update this in as many places in the marketing + app itself.

@tzjames tzjames requested a review from lukesonnet July 4, 2023 13:44
@tzjames tzjames requested a review from lukesonnet July 6, 2023 15:44
@tzjames tzjames merged commit f3b6a35 into main Jul 7, 2023
5 checks passed
@tzjames tzjames deleted the doc_reorg branch July 7, 2023 09:52
tzjames added a commit that referenced this pull request Jul 7, 2023
tzjames added a commit that referenced this pull request Jul 7, 2023
@tzjames tzjames mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants