Enable SSE support for Cloud using staged rollout (GB feature flag) #1426
Conversation
|
Your preview environment pr-1426-bttf has been deployed. Preview environment endpoints are available at: |
|
Deploy preview for docs ready! ✅ Preview Built with commit c11d777. |
…ookup logic, refactor
| @@ -80,7 +84,8 @@ export default function SDKConnectionsList() { | |||
| {connections.map((connection) => { | |||
| const hasProxy = | |||
| !isCloud() && connection.proxy.enabled && connection.proxy.host; | |||
| const hasCloudProxyForSSE = isCloud() && connection.sseEnabled; | |||
| const hasCloudProxyForSSE = | |||
| isCloud() && growthbook?.isOn("proxy-cloud-sse"); | |||
There was a problem hiding this comment.
We're not using this feature flag anymore, right?
There was a problem hiding this comment.
we're using this temporarily until 100% rollout, just so we can show accurate info in the UI
| host: proxy.host ? proxy.host : PROXY_HOST_INTERNAL || PROXY_HOST_PUBLIC, | ||
| hostExternal: proxy.hostExternal | ||
| ? proxy.hostExternal | ||
| : PROXY_HOST_PUBLIC || PROXY_HOST_INTERNAL, |
There was a problem hiding this comment.
What's the purpose of this change? I think this might break self-hosted users who are using a proxy with environment variables.
There was a problem hiding this comment.
I believe the original function breaks our "local proxy for cloud users" functionality: They need to be able to set enabled and host from the SDK Connection UI, but then this method overwrites these fields with env var defaults. And even if they aren't actually set in our cloud environment, we'd still overwrite with "". We need a way to only set these fields if nothing is being provided by ...proxy.
I don't fully understand the point of hostExternal so I'm not confident that I got this part correct.
Features and Changes
Cloud:
Dependencies
Testing
Screenshots