Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with results not showing in presentations. #1459

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

Auz
Copy link
Contributor

@Auz Auz commented Jul 13, 2023

Fixed an error where results are not shown in presentations due to a change in the data structure for snapshot results. Also fixed errors related to possibly undefined variables.
Fixes #1456

@github-actions
Copy link

Your preview environment pr-1459-bttf has been deployed.

Preview environment endpoints are available at:

lukesonnet
lukesonnet previously approved these changes Jul 13, 2023
@lukesonnet lukesonnet self-requested a review July 13, 2023 23:27
@lukesonnet lukesonnet dismissed their stale review July 13, 2023 23:27

actually found a bug!

Copy link
Collaborator

@bttf bttf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but maybe a second review might do well

packages/front-end/components/Share/Presentation.tsx Outdated Show resolved Hide resolved
packages/front-end/components/Share/Presentation.tsx Outdated Show resolved Hide resolved
packages/front-end/components/Share/ShareModal.tsx Outdated Show resolved Hide resolved
@Auz Auz merged commit 61599c2 into main Jul 17, 2023
3 checks passed
@Auz Auz deleted the 1456-presentation-bug branch July 17, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Presentations are not showing results from experiment
4 participants