Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-arrange Metrics text for Ratio Metrics #1465

Merged
merged 2 commits into from Jul 19, 2023
Merged

Re-arrange Metrics text for Ratio Metrics #1465

merged 2 commits into from Jul 19, 2023

Conversation

lukesonnet
Copy link
Contributor

Features and Changes

  • alerts that #s and graphs on metrics page don't include denominator for ratio metrics.
  • Moves segment picker to same row as data preview

before

Screenshot 2023-07-14 at 11 51 25 AM

after (non-ratio metric)

Screenshot 2023-07-14 at 11 51 14 AM

after (ratio metric)

Screenshot 2023-07-14 at 11 51 07 AM

@github-actions
Copy link

Your preview environment pr-1465-bttf has been deployed.

Preview environment endpoints are available at:

@lukesonnet lukesonnet merged commit 5b0c68b into main Jul 19, 2023
4 checks passed
@lukesonnet lukesonnet deleted the ls/rmid branch July 19, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdorn jdorn jdorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukesonnet @jdorn