Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API - POST Experiments - Remove required legacy field #1466

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

bttf
Copy link
Collaborator

@bttf bttf commented Jul 14, 2023

implementation on the Experiment model is no longer used by our existing frontend flows and is virtually always set to 'code' on the backend. This removes the field from the POST /experiments API payload so it is no longer required

@github-actions
Copy link

Deploy preview for docs ready!

✅ Preview
https://docs-hsno05h6w-growthbook.vercel.app

Built with commit be10eb3.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Your preview environment pr-1466-bttf has been deployed.

Preview environment endpoints are available at:

@bttf bttf marked this pull request as ready for review July 14, 2023 21:19
@bttf bttf requested review from jdorn and a team July 14, 2023 21:27
Copy link
Contributor

@lukesonnet lukesonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm feel free to wait if you want another pair of eyes though as this isn't really pressing

@bttf bttf merged commit 950e68b into main Jul 14, 2023
5 checks passed
@bttf bttf deleted the adnan/exp-rest-api-implementation-field branch July 14, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants