Parameterize sample data generator #1486
Conversation
|
Your preview environment pr-1486-bttf has been deployed. Preview environment endpoints are available at: |
| s.setDate(s.getDate() + start); | ||
| e.setDate(e.getDate() + end); | ||
| s.setDate(s.getDate() + startPct * dateLength); | ||
| e.setDate(e.getDate() + endPct * dateLength); |
There was a problem hiding this comment.
We may want to consider using date-fns to clean up a lot of the date manipulation in this part of the codebase. Existing example below
There was a problem hiding this comment.
I use addDays to clean this up in a few places but I didn't want to refactor everything else for this standalone script because much of it relies on in-place manipulations of the date. ty.
|
|
||
| const NUM_USERS = 10000; | ||
| const OUTPUT_DIR = "/tmp/csv"; | ||
| import { int } from "aws-sdk/clients/datapipeline"; |
There was a problem hiding this comment.
This is likely a typo. I'm guessing you meant to use number instead of int as a type somewhere and your IDE autocompleted to this
There was a problem hiding this comment.
yeah i can't shake the urge to int. fixed.
Features and Changes
Testing
Ran script, values and number of events in line with before change. Not pivotal to be identical!