Adds error check on Experiment results page #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-1507-bttf has been deployed. Preview environment endpoints are available at: |
…ngoose update - we can no longer pass in undefined, it has to be null or an empty string.
jdorn
reviewed
Jul 26, 2023
| @@ -118,6 +118,7 @@ export async function updateReport( | |||
| $set: { | |||
| ...updates, | |||
| dateUpdated: new Date(), | |||
| error: updates.error || "", | |||
There was a problem hiding this comment.
I don't think this is right place for this. If someone just edits the report name, this will now delete the error. I think this belongs in the ReportQueryRunner class instead. That's where we call updateReport
There was a problem hiding this comment.
Ah, yea - good call. Updated.
jdorn
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
On the experiment report page, we're now checking if a report has an error via
report.errorand if so, displaying a red warning icon. On hover, we display a tooltip that displays the error string.Additionally, on the report id page
[rid].tsxwe're also surfacing any error message on the report itself, rather than making the user open the modal to see if there is an error.Also included in this PR is an update to how we're handling the
updateReportmethod within theReportModel. Similar to this PR Mongoose doesn't acceptundefinedwhen calling$setand spreading in the updates. As a result, if a report had an error, but the error was resolved, it wasn't actually getting reset. With this update, we're now successfully resetting an error message if it's been resolved.Testing
Screenshots