Add better warning message #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tinahollygb I'm not sure exactly how this breaks on the client side of people using older sdks. But perhaps we could do something to make it less painful for them - like detect that they are on an old sdk, filter out newer formats that would break them, and send them a warning message somehow. |
|
Your preview environment pr-1508-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Add a better warning message for using the version string format.
This was inspired by James Billingham: https://growthbookusers.slack.com/archives/C01T6Q0TEG3/p1690329200317749
Testing
Create a string attribute with a version string format. See the new error message
Screenshots