New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshot analysis creation/lookup, baseline chooser #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your preview environment pr-1515-bttf has been deployed. Preview environment endpoints are available at: |
… to original variation order
…g' into ls/analysis_baseline
lukesonnet
changed the base branch from
main
to
results-table-variation-filtering
August 30, 2023 15:06
lukesonnet
changed the title
[WIP] Add snapshot analysis creation/lookup and baseline variation switcher
[WIP] Add snapshot analysis creation/lookup
Aug 30, 2023
lukesonnet
commented
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't approve my own PR, but this looks good to me. One comment about the UX when running queries and another tiny comment.
packages/front-end/components/Experiment/AnalysisSettingsBar.tsx
Outdated
Show resolved
Hide resolved
…d triggers analysis
bryce-fitzsimons
changed the title
[WIP] Add snapshot analysis creation/lookup
Add snapshot analysis creation/lookup, baseline chooser
Aug 31, 2023
bryce-fitzsimons
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
As part of the Snapshot Refactor (#1284), one of the key next steps was enabling creating multiple analyses that rely on one snapshot and set of queries. This would be done through quick calls to
gbstats
, stored side-by-side, and accessed by theirExperimentSnapshotAnalysisSettings
which represents meta-data about the analysis.This PR is one way to achieve this goal with the new Snapshot model, and use it for a simple feature.
createSnapshotAnalyses
which can create multiple snapshot analyses. Much of this code duplicatesExperimentQueryRunner
so we should consider how to keep this dry.useSnapshot()
to allow for setting theExperimentSnapshotAnalysisSettings
on the fly and to retrieve the right data for a given analysisSettings object.TODO:
BaselineChooser
Here's the call that this PR used to fire in
AnalysisSettingsBar
when you messed with the baseline chooser I had built into an old commit (but have ripped out when rebasing onresults-table-variation-filtering
:Dependencies
#1631
Testing
TODO