Make growthbook image multi-platform #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzjames
changed the title
|
Deploy preview for docs ready! ✅ Preview Built with commit 41fc096. |
|
Looks like this has been tested and confirmed working? |
Yes on Apple Silicon I have confirmed it works. I don't have another system handy to test it out on for other platforms. It would probably be good to double check. |
@jdorn Has a non-Apple machine IIRC |
tzjames
changed the title
jdorn
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
According to https://github.com/depot/build-push-action
platformstakes a csv list of platforms to build for. And according to https://depot.dev/docs/guides/arm-containers#what-about-multi-platformmulti-architecture-containers depot can create a multi-platform image with zero emulation. This should hopefully then allow our same docker compose file to work whether it is on Apple Silicon or not.Testing
As this only gets triggered during the deploy process, I created a new manual workflow. The image got created with multiplatform tag. Then modified docker-compose.yml to use :multiplatform instead of :latest. Then try
docker-compose up -don Apple Silicon. See it working.