New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce team management UI #1657
Conversation
Your preview environment pr-1657-bttf has been deployed with errors. |
@mknowlton89 pointed out a bug with adding members to a team where all the requested members don't always get added. Have been able to replicate but bug is flaky so still trying to track down what may be causing it to happen sporadically. |
members: string[]; | ||
}>({ | ||
defaultValues: { | ||
members: data?.team.members?.map((m) => m.id) || [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always be an empty array. data
is not defined on initial load and I believe useForm ignores changes to defaultValues
.
I think we can get rid of the useApi
call completely here, right? From what I can tell, this modal is about adding new users, so we don't really care who the existing users are and should always set this to an empty string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to check the existing members of the team to determine what the addableMembers
are so we can populate the options for the MultiSelectField
but an alternative could be to pass that in from the team page as a prop instead of doing another API call here. Agree that we don't need to default members to anything other than an empty array though.
…t value for AddMembersModal to an empty array
Features and Changes
Introduce a team management UI within the Team tab. Allows users to create teams within the GrowthBook UI as well as via SCIM (currently only works with Okta.) Any teams created via SCIM will need to have membership and name changes done through Okta rather than the GrowthBook UI.
Dependencies
#1762
Testing
Attempt to do CRUD operations for teams
Test features being blocked for manageByIdp teams (Name changes, membership changes)
managedByIdp
to trueScreenshots
Teams tab
Create Team Modal
GrowthBook Managed Team
Okta Managed Team
Add Team Members Modal
Teams page with upgrade message