Extend unit creation pipeline mode to snowflake #1691
Conversation
|
Your preview environment pr-1691-bttf has been deployed. Preview environment endpoints are available at: |
| } | ||
|
|
||
| // Add schema if required | ||
| if (this.requiresSchema) { | ||
| if (this.requiresSchema || requireSchema) { |
There was a problem hiding this comment.
Not blocking, but perhaps there is a better variable name for requireSchema. Maybe queryRequiresSchema - it took me a minute to understand the different between requireSchema and this.requiresSchema.
There was a problem hiding this comment.
LGTM - Left one comment/suggestion on a variable name.
I tested this with some of my existing data sources (GA4, Segment, Snowflake) and I didn't run into any issues with creating the datasource, building the information_schema, or building any automatic metrics (only GA4 & Segment support that, currently).
I don't know how to test the net-new logic around the pipeline - if you'd like me to test it, just lmk and we can sync up on steps to do so.
|
As per offline discussion, the quotes aren't necessary, so I removed that and took your other advice. Re-tested and everything is working for snowflake info schemas and creating tables (on my end). |
Features and Changes
Allows units table creation for Snowflake integration.
Required some tweaks to our ability to create table paths.
Testing
Works in localhost connected to my snowflake.
Permissions are a little wonky so will need good docs here.