Update putDataSource to handle removing description.

[mknowlton89]

Features and Changes

This PR updates the putDataSource method. Initially, this update was just to resolve a bug where the description of a data source object wasn't able to be removed. With the way the code was written, we were only updating the datasource description if a description was passed in - and when removing the description, an empty string is passed in, so the if (datasource) check was returning false, and thus skipping the code that actually updates the description.

In looking at the endpoint further, we're actually always passing in a full datasource object (save the dateCreated/dateUpdated fields), so all of the checks in the method that were checking for various properties were unnecessary.

This PR removes the unneeded checks and simplifies the method.

• Closes [Bug] Unable to remove data source description #1517

Testing

• Confirm that if you remove a description from a data source via the DataSourceForm, the description is actually removed.
• Confirm no new regressions are introduced with this refactor
• Confirm the ability to create a data source still works via this form
• Confirm the ability to edit the name of a data source still works via this form
• Confirm the ability to edit multiple fields on this data source object still works via this form

[mknowlton89]

There is only one place in the app where we're hitting this endpoint, and we're passing in the full "Datasource" object, not just the updates, so description will always be provided, it may just be an empty string. Same with projects

[jdorn]

Is this true? It looks like it's also called in [did].tsx where only settings and nothing else is passed in.

[mknowlton89]

I don't know how I missed that. I've updated this PR in light of this. I mostly reset everything, and when it comes to the description, I'm checking to see if the description property exists in the req.body, and if so, then setting using the value to update the description.

[github-actions]

Your preview environment pr-1765-bttf has been deployed.

Preview environment endpoints are available at:

• https://growthbook-3000-pr-1765-bttf.growthbook.okteto.dev
• https://growthbook-3100-pr-1765-bttf.growthbook.okteto.dev