Move URL check higher up SDK _run chain #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-1883-bttf has been deployed. Preview environment endpoints are available at: |
bttf
force-pushed
the
adnan/fix-preview-links
branch
from
ce01b5b
to
63c5245
Compare
|
We should add a unit test for this - one that fails on |
bttf
force-pushed
the
adnan/fix-preview-links
branch
from
63c5245
to
be7c51a
Compare
Tests added for existing and new functionality re: preview links in the SDK |
jdorn
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug occurring with visual experiments and preview links when the experiment had multiple pages.
It effectively moves our URL targeting check up in the series of checks in
_runso that we exit earlier for experiments that do not have applicable URL targeting.Tested locally and works as expected