Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Papercups with Pylon #1948

Merged
merged 3 commits into from Dec 18, 2023
Merged

Replace Papercups with Pylon #1948

merged 3 commits into from Dec 18, 2023

Conversation

mknowlton89
Copy link
Collaborator

@mknowlton89 mknowlton89 commented Dec 13, 2023

Features and Changes

This PR updates our In-App chat widget to use the Pylon chat widget, rather than the Papercups widget. Accompanied by this, is a new Feature Flag in our GrowthBook org for pylon-config.

This PR doesn't change any of the logic of who gets this in-app chat widget, vs the other help widget.

Screenshots

Screen Shot 2023-12-13 at 2 28 29 PM Screen Shot 2023-12-14 at 6 37 08 AM Screen Shot 2023-12-13 at 2 28 46 PM

@mknowlton89 mknowlton89 self-assigned this Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

Your preview environment pr-1948-bttf has been deployed.

Preview environment endpoints are available at:

@august-growthbook
Copy link
Contributor

Looks great! Do you know why the icon for the docs isn't showing up in the widget in the 2nd screenshot?

@august-growthbook august-growthbook added the enhancement New feature or request label Dec 13, 2023
@mknowlton89
Copy link
Collaborator Author

Looks great! Do you know why the icon for the docs isn't showing up in the widget in the 2nd screenshot?

I don't - I looked through the Pylon app, and I see where I can set an icon for the Docs link, but I don't see how I can add a URL for an image. You can update the icon here.

For now, I just selected a stack of books as a placeholder. You're welcome to change it via the link above.

Screen Shot 2023-12-14 at 6 37 08 AM

@mknowlton89 mknowlton89 marked this pull request as ready for review December 14, 2023 11:38
@@ -8,36 +8,33 @@ import { GBPremiumBadge } from "../Icons";
import UpgradeModal from "../Settings/UpgradeModal";

export default function InAppHelp() {
const config = useFeature("papercups-config").value;
const { app_id, script_content } = useFeature("pylon-config").value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature value will be null if there's a network problem or the feature is toggled off for some reason. That will throw an exception here since you are using object destructuring on it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you!

@mknowlton89 mknowlton89 merged commit ec88dce into main Dec 18, 2023
3 checks passed
@mknowlton89 mknowlton89 deleted the mk/pylon-in-app-chat branch December 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants