Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jStat with stdlib #2011

Merged
merged 2 commits into from Jan 9, 2024
Merged

Replace jStat with stdlib #2011

merged 2 commits into from Jan 9, 2024

Conversation

jdorn
Copy link
Member

@jdorn jdorn commented Jan 9, 2024

Features and Changes

Replace the jStat library, which is unmaintained and untyped, with the @stdlib library. The functions are a 1-to-1 swap.

@jdorn jdorn requested a review from lukesonnet January 9, 2024 15:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Your preview environment pr-2011-bttf has been deployed.

Preview environment endpoints are available at:

lukesonnet
lukesonnet approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@lukesonnet lukesonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, stdlib docs look decent and it is reasonably active!

packages/back-end/src/util/stats.ts Outdated Show resolved Hide resolved
@jdorn jdorn merged commit af77da1 into main Jan 9, 2024
3 checks passed
@jdorn jdorn deleted the stdlib branch January 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesonnet lukesonnet lukesonnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdorn @lukesonnet