[bugfix] prevent undefined query result rows from breaking stats engine #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2023-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer may have hit a case where
rowshere is actually undefined:https://github.com/growthbook/growthbook/blob/main/packages/back-end/src/services/stats.ts#L99-L107
Because we just tell Typescript that something potentially undefined (query.result) should be
ExperimentMetricQueryResponseRows, we should just be safe and let undefined be treated the same as an empty list if they get to this part.Shouldn't happen if query status is "finished", but maybe it's related to allowing partially completed data to go to the stats engine.