First pass at updating the ExperimentModel #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the middleware.
…ion to get readAccessFilter for apiKey.
…-and-feature-model
5 tasks
…ture.id correctly.
…ed a duplicate call.
|
Your preview environment pr-2055-bttf has been deployed with errors. Preview environment endpoints are available at: |
jdorn
reviewed
Jan 25, 2024
jdorn
reviewed
Jan 25, 2024
…property in the findOne query and reverts some changes to the sdkWebhook job.
jdorn
approved these changes
Jan 25, 2024
itsgrimetime
pushed a commit
to itsgrimetime/growthbook
that referenced
this pull request
Jan 30, 2024
Update ExperimentModel to filter experiments based on user's read access permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
This PR primarily updates the
ExperimentModelfile to filter resources based on the user's read access level. In doing so, I did have to update 42 other files that ultimately consume the functions that are defined in the ExperimentModel file.Testing
/experimentspagenoaccessand project-level role grants experimenter access) and ensure only experiments in the project the user has access to is visiblenoaccessrole for 1 project and ensure experiments from that project are not visiblenoaccessrole forScreenshots