Add hashing v1 notifications/selector when SDK doesn't support v2 #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2097-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
reviewed
Feb 13, 2024
packages/front-end/components/Experiment/EditTargetingModal.tsx
Outdated
Show resolved
Hide resolved
|
Deploy preview for docs ready! ✅ Preview Built with commit 2a9898e. |
bryce-fitzsimons
force-pushed
the
add-v1-hashing-ui-for-old-sdks
branch
from
2a9898e
to
370b16b
Compare
jdorn
reviewed
Feb 23, 2024
jdorn
reviewed
Feb 23, 2024
Co-authored-by: Jeremy Dorn <jeremy@jeremydorn.com>
jdorn
reviewed
Feb 26, 2024
packages/front-end/components/Experiment/EditTargetingModal.tsx
Outdated
Show resolved
Hide resolved
jdorn
reviewed
Feb 26, 2024
jdorn
reviewed
Feb 26, 2024
packages/front-end/components/Experiment/HashVersionSelector.tsx
Outdated
Show resolved
Hide resolved
jdorn
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Warn when using v1-only SDK, add hash version select field, default to v1 when v2 is unsupported
Dependencies
Testing
Screenshots