Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric window graphic and add second example #2181

Merged
merged 1 commit into from Feb 29, 2024
Merged

Conversation

lukesonnet
Copy link
Contributor

The labels on the metric window graphic were incorrect. I also added a second graphic showing that conversion windows extend beyond the experiment end date.

Copy link

Deploy preview for docs ready!

✅ Preview
https://docs-o5aq9afj0-growthbook.vercel.app

Built with commit 527773e.
This pull request is being automatically deployed with vercel-action

Copy link
Collaborator

@gazzdingo gazzdingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gazzdingo gazzdingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukesonnet lukesonnet merged commit 98cb6ed into main Feb 29, 2024
4 checks passed
@lukesonnet lukesonnet deleted the ls/window-docs branch February 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants