Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 20 #2190

Merged
merged 26 commits into from
Apr 16, 2024
Merged

node 20 #2190

merged 26 commits into from
Apr 16, 2024

Conversation

gazzdingo
Copy link
Collaborator

Features and Changes

  • Closes (add link to issue here)

Dependencies

Testing

Screenshots

Guy Langford-Lee added 2 commits March 4, 2024 14:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Deploy preview for docs ready!

✅ Preview
https://docs-2hbn2p29i-growthbook.vercel.app

Built with commit 46bdd74.
This pull request is being automatically deployed with vercel-action

gazzdingo
gazzdingo commented Mar 5, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@gazzdingo
Copy link
Collaborator Author

we might want to test this a bunch :)

@jdorn
Copy link
Member

jdorn commented Mar 6, 2024

Code looks good. Mark this as "Ready for review" and it will spin up the PR Preview Environment, which will let us test the Docker build.

@gazzdingo gazzdingo marked this pull request as ready for review March 6, 2024 17:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

Your preview environment pr-2190-bttf has been deployed.

Preview environment endpoints are available at:

mknowlton89
mknowlton89 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@mknowlton89 mknowlton89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pulled this down and ran it locally without issue. Ran through some common flows. Looking through the release docs for v20, I don't see anything that stands out as risky.

jdorn
jdorn requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jdorn jdorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some issues with the preview environment. Need to investigate this first

Guy Langford-Lee added 2 commits April 9, 2024 12:39
@gazzdingo gazzdingo requested a review from jdorn April 9, 2024 20:12
@gazzdingo
Copy link
Collaborator Author

added post install to both places and it worked

@gazzdingo gazzdingo merged commit a7932d4 into main Apr 16, 2024
6 checks passed
@gazzdingo gazzdingo deleted the gl/node-20 branch April 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdorn jdorn jdorn approved these changes

@mknowlton89 mknowlton89 mknowlton89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gazzdingo @jdorn @mknowlton89