Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn generate-sdk-report command #2197

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

mkurkov
Copy link
Contributor

@mkurkov mkurkov commented Mar 6, 2024

Features and Changes

  • Adds yarn generate-sdk-report command
  • Generated report saved to packages/shared/src/sdk-versioning/CAPABILITIES.md file

Had to tweak prettier/eslint config:

  • Prettier ignores generated packages/shared/src/sdk-versioning/CAPABILITIES.md file
  • console-log warning switched of for packages/shared/src/sdk-versioning/sdk-report.ts script

Dependencies

Added ts-node as dep to shared package

Testing

Just run yarn generate-sdk-report command. If any of packages/shared/src/sdk-versioning/sdk-versions/*.json files changed CAPABILITIES.md file should be updated.

Screenshots

image

@bttf bttf self-assigned this Apr 15, 2024
Copy link
Collaborator

@bttf bttf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a few nitpicks but otherwise looks good.

One request is that we change from using ts-node to using swc-node

packages/shared/src/sdk-versioning/sdk-report.ts Outdated Show resolved Hide resolved
packages/shared/src/sdk-versioning/sdk-report.ts Outdated Show resolved Hide resolved
packages/shared/src/sdk-versioning/sdk-report.ts Outdated Show resolved Hide resolved
packages/shared/src/sdk-versioning/sdk-report.ts Outdated Show resolved Hide resolved
@mkurkov
Copy link
Contributor Author

mkurkov commented Apr 18, 2024

@bttf thanks for the review, all issues should be fixed now.

Copy link
Collaborator

@bttf bttf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good. Made a couple minor tweaks, will merge shortly.

@bttf bttf merged commit c6b6f99 into growthbook:main Apr 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants