New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves Attribute filtering by project #2226
Conversation
…ute in new experiment form.
Your preview environment pr-2226-bttf has been deployed. Preview environment endpoints are available at: |
Saved groups are not project-scoped right now. Also, should add to your list of tests to make sure editing an existing rule that references an out-of-project attribute continues to work. It may switch them to advanced mode, which is fine, as long as it's still editable. |
…oups project scoped.
… attribute no longer associated with the feature's project.
Great suggestion. I've removed the filtering from saved groups until we add project scoping to saved groups. I also updated the rule modal so if a user is editing an existing rule that references an attribute no longer associated with the feature's project, it automatically switches to advanced mode. Previously, it was displaying an empty |
Features and Changes
With the recently introduced feature of project-scoping attributes, we weren't properly filtering the list of attributes all the way in a few different places, based on the resource's project.
Ex:
For a feature that is in project A, when creating a rule, we should automatically filter the list of attributes to only attributes available to Project A (which would be any attribute in project A, or any attribute in "All Projects".
Previously, we were filtering based on a user's readAccess, but not also by project.
Testing
no_access
roles, as a result of these changes