Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing logs with auth tokens #2327

Merged
merged 1 commit into from Apr 2, 2024
Merged

Conversation

jdziat
Copy link
Contributor

@jdziat jdziat commented Apr 2, 2024

Features and Changes

Updating logging redacted paths to include the cookies being sent in the response.

Example log message with authentication information included:

{
  "level": 30,
  "time": 1712058434895,
  "pid": 58,
    "req": {
    "id": 3556,
    "method": "POST",
    "url": "/auth/refresh",
    "query": {
    },
    "params": {
    },
    "headers": {

    }
  },
  "res": {
    "statusCode": 200,
    "headers": {
      "vary": "Origin, Accept-Encoding",
      "set-cookie": [
        "AUTH_ID_TOKEN=<<redacted>>; Max-Age=1; Path=/; Expires=Tue, 02 Apr 2024 11:47:16 GMT; HttpOnly",
        "AUTH_REFRESH_TOKEN=<<redacted>>; Max-Age=2592000; Path=/; Expires=Thu, 02 May 2024 11:47:14 GMT; HttpOnly"
      ],
      "content-type": "application/json; charset=utf-8",
      "content-length": "424"
    }
  },
  "responseTime": 17,
  "msg": "request completed"
}

Dependencies

Testing

Screenshots

@jdorn jdorn merged commit cf1b58d into growthbook:main Apr 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants