Fix namespace usage includes inactive experiments #2343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
When calculating which part of a namespace was being used, we weren't properly filtering out experiments that were stopped or inactive in some way.
Now it excludes if any of the following are true:
We ARE still including draft experiments and feature rules. We do this to avoid race conditions where two drafts are being worked on at the same time. We want them to be aware of each other when configuring namespaces since we don't know when they will launch.