Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: refreshing archetype view/data when archetypes change #2369

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

bryce-fitzsimons
Copy link
Member

Features and Changes

  • Force a refresh (refetch) of archetypes + results whenever archetypes change (add, remove, change).

Dependencies

Testing

Screenshots

Copy link

Your preview environment pr-2369-bttf has been deployed.

Preview environment endpoints are available at:

Copy link
Contributor

@romain-growthbook romain-growthbook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straight forward to me.

Could this be rewritten as a SWR hook to follow the usual mutate workflow? That would also re-fetch for all spots that use this endpoint across the app if there are more.

@bryce-fitzsimons
Copy link
Member Author

This looks straight forward to me.

Could this be rewritten as a SWR hook to follow the usual mutate workflow? That would also re-fetch for all spots that use this endpoint across the app if there are more.

@romain-growthbook
Yes we probably could, but couldn't figure out a quick way to do it in the context of this hotfix... Open to ideas though for a fast follow

@bryce-fitzsimons bryce-fitzsimons merged commit c7eb3d5 into main Apr 10, 2024
3 checks passed
@bryce-fitzsimons bryce-fitzsimons deleted the bryce/fix-archetype-refresh branch April 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants