Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve past experiment imports #2437

Merged
merged 7 commits into from
May 3, 2024
Merged

Improve past experiment imports #2437

merged 7 commits into from
May 3, 2024

Conversation

jdorn
Copy link
Member

@jdorn jdorn commented Apr 28, 2024

Features and Changes

This PR fixes a number of UX and performance issues when importing existing experiments from a data source into GrowthBook.

Changes:

  • Improve labels, headers, and tooltips to be more intuitive
  • Perform incremental updates when refreshing the list (with option to do a full refresh)
  • On initial load, do not start the query immediately. Tell the user we are about to scan X days of data and have them confirm before starting.
  • Move all filtering from the back-end to the UI and persist in localStorage to make exploration and debugging easier.
  • Smarter logic for guessing variation weights, plus warn in UI that this is a guess and might be inaccurate
  • Right after importing an experiment, auto-update results (opt-out toggle)

Screenshots

Note: My local IMPORT_LIMIT_DAYS variable is set to 2000 in the screenshots below. The default value is 365.

image

image

image

image

image

image

New toggle when importing to auto-run result queries on save (default ON):

image

@jdorn jdorn marked this pull request as ready for review April 28, 2024 19:53
@jdorn jdorn requested a review from lukesonnet April 28, 2024 19:53
Copy link

Your preview environment pr-2437-bttf has been deployed.

Preview environment endpoints are available at:

Copy link
Contributor

@lukesonnet lukesonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems to work with some light QA and quick code review. Some nits were shared with you in comments.

@jdorn jdorn merged commit da0234b into main May 3, 2024
3 checks passed
@jdorn jdorn deleted the import-exp-improvements branch May 3, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants