Set results UI denominator correctly when it is 0 #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2448-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a denominator is 0 for a ratio metric, we should return that rather than fall back to users. This PR does that.
Because the stats engine will always return denominator = 0 for non-ratio metrics, we have to use the kind of logic I've built into the FE here.
This PR also allows for any non-binomial metric to be a ratio denominator (for classic metrics), not just count metrics.
Before (non-sensical results):
After (more sensical results):
