add deploy job step to push static files to s3 #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
On each deploy some frontends that were loaded from an old server might try and read the files from a new server and vice-versa. This PR will send the files to a new s3 bucket. All the files that next makes have a hash appended to the file name so they can live in the same directory. Both old and new files should be available at deploy time then.
We will then update the load balancer to send requests to /_next/static to instead be re-routed either to our cdn or directly to s3.
Test Plan
Ran the commands locally.
Saw the files get to S3: https://us-east-1.console.aws.amazon.com/s3/buckets/growthbook-cloud-static-files?region=us-east-1&bucketType=general&tab=objects