Fix organization prior settings #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bttf
approved these changes
May 14, 2024
Comment on lines
+399
to
+404
| (metricDefaults.priorSettings ?? { | ||
| override: false, | ||
| proper: false, | ||
| mean: 0, | ||
| stddev: DEFAULT_PROPER_PRIOR_STDDEV, | ||
| }), |
There was a problem hiding this comment.
should the { override: false, ... } object be defined as a default in shared/constants?
| // Metric defaults are nested, so take existing metric defaults only if | ||
| // they exist and are not empty | ||
| Object.keys(newVal[k]).forEach((kk) => { | ||
| newVal[k][kk] = settings?.[k]?.[k] ?? newVal[k][kk]; |
There was a problem hiding this comment.
This is accomplishing the same as if you used the spread operator (...), with settings spread first. Any reason you wouldn't want to do it that way?
There was a problem hiding this comment.
It needs to spread settings?.[k] which could work.
|
Your preview environment pr-2518-bttf has been deployed. Preview environment endpoints are available at: |
|
ty, landing in the interest of time, your feedback is useful and i can do it in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with setting priors at the org level
Previously,
settingsfrom the userContext (which pulls from the DB) would be clobbering the sub-fields ofmetricDefaultsthat were initialized in the form defaultValues. This isn't a problem for other fields that are not nested, but it is a problem formetricDefaults.priorSettingswhich will be missing in most databases.This fixes that issue in the org settings and makes the FE a bit more robust to this issue.
A migration might be a better solution, to be honest.