Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must select value type of new feature instead of defaulting to Boolean #2553

Merged
merged 2 commits into from
May 21, 2024

Conversation

jdorn
Copy link
Member

@jdorn jdorn commented May 21, 2024

Features and Changes

When creating a new feature, we now require you to select the value type instead of defaulting to Boolean.

This addresses an issue where users mistakenly create Boolean flags for things they meant to be strings/json. By forcing people to make a choice, we hope to reduce these accidents.

This PR also re-orders the value type options. It now goes Boolean -> String -> Number -> JSON

New default modal view:

image

@jdorn jdorn changed the title Must pick value type of new feature instead of defaulting to Boolean Must select value type of new feature instead of defaulting to Boolean May 21, 2024
Copy link

github-actions bot commented May 21, 2024

Your preview environment pr-2553-bttf has been deployed.

Preview environment endpoints are available at:

@jdorn jdorn merged commit ec4dcfd into main May 21, 2024
3 checks passed
@jdorn jdorn deleted the optin-feature-value-type branch May 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants