Custom aggregation for Mixpanel metrics #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/growthbook/docs/Dc1JGQhKK5GJdY1TrTJuxBJ737Ru [Deployment for 0fbf8f1 canceled] |
jdorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For count, revenue, and duration metrics in Mixpanel, the aggregation method is currently hard-coded as a sum. This PR allows users to override this default behavior.
The default behavior remains the same (sum the values):
values.reduce((sum,n) => sum+n, 0)Now you can do something like COUNT DISTINCT:
new Set(values).sizeOr MAX:
Math.max(...values)Or anything else you want to do.
This PR also makes the event value more flexible. Before, you could only specify properties, now you can specify entire javascript expressions. For example:
event.properties.end - event.properties.startorMath.pow(event.properties.x, 2)