-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to react-hook-form instead of custom form library #78
Conversation
This pull request is being automatically deployed with Vercel (learn more). app – ./packages/front-end/🔍 Inspect: https://vercel.com/growthbook/app/Fns2MtqK77xyHEbShisBduVUcAzV docs – ./packages/docs🔍 Inspect: https://vercel.com/growthbook/docs/J2L7A3CCgdDMnakwFtd4ZRtcqdMA [Deployment for bc857b3 canceled] |
Our custom
useForm
hook has some major issues - it doesn't work well for number inputs (#74 ), has no validation logic built-in, and causes way too many React re-renders. Instead of fix these problems, we are switching to the popularreact-hook-form
which has already solved all of these issues and is actively maintained.TODO:
<Field>
componentForms to convert: