-
Notifications
You must be signed in to change notification settings - Fork 5
/
Lcom4AnalyzerTest.cs
571 lines (460 loc) · 11.2 KB
/
Lcom4AnalyzerTest.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Text;
using System.Threading;
using Gendarme.Framework;
using Mono.Cecil;
using NUnit.Framework;
namespace DependencyParser.Test {
[NUnit.Framework.TestFixture]
public class Lcom4AnalyzerTest {
[Test]
public void Should_Find_One_Block_On_A_Simple_Class()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClass"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Find_Two_Blocks_On_A_Simple_Stateless_Class()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleCalculator"));
Assert.AreEqual(2, blocks.Count);
}
[Test]
public void Should_Find_One_Block_On_A_Class_With_Strong_Cohesion()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.ClassWithManyMethodsAndStrongCohesion"));
Assert.AreEqual(1, blocks.Count);
Assert.AreEqual(5, blocks.ElementAt(0).Count);
}
[Test]
public void Should_Ignore_Simple_Accessors()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.ClassWithProperties"));
Assert.AreEqual(0, blocks.Count);
}
[Test]
public void Should_Take_In_Account_Calls_To_Simple_Accessors()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.ClassWithCallsToAccessors"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Take_In_Account_Complex_Accessors()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.ClassWithComplexProperties"));
Assert.AreEqual(2, blocks.Count);
}
[Test]
public void Should_Ignore_Abstract_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.AbstractClass"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Take_In_Account_Calls_To_Abstract_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.AbstractTemplateClass"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Ignore_Empty_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.ClassWithEmptyMethods"));
Assert.AreEqual(0, blocks.Count);
}
[Test]
public void Should_Take_In_Account_Calls_Ignore_Empty_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.ClassWithCallsToEmptyMethods"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Ignore_Constructors()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClassWithCtr"));
Assert.AreEqual(2, blocks.Count);
}
[Test]
public void Should_Not_Fail_On_Empty_Interface()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.IEmpty"));
Assert.AreEqual(0, blocks.Count);
}
[Test]
public void Should_Not_Fail_On_Empty_Class()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.EmptyClass"));
Assert.AreEqual(0, blocks.Count);
}
[Test]
public void Should_Not_Take_In_Account_Dispose_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleDisposableClass"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Not_Take_In_Account_Equals_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClassWithEquals"));
Assert.AreEqual(2, blocks.Count);
}
[Test]
public void Should_Not_Take_In_Account_ToString_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClassWithToString"));
Assert.AreEqual(2, blocks.Count);
}
[Test]
public void Should_Not_Take_In_Account_Methods_From_Wrapped_Objects()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClassWithDelegation"));
Assert.AreEqual(1, blocks.Count);
Assert.AreEqual(3, blocks.ElementAt(0).Count);
}
[Test]
public void Should_Not_Take_In_Account_Inherited_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.DerivedClass"));
Assert.AreEqual(1, blocks.Count);
Assert.AreEqual(3, blocks.ElementAt(0).Count);
}
[Test]
public void Should_Not_Take_In_Account_Static_Methods()
{
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClassWithStaticMethod"));
Assert.AreEqual(1, blocks.Count);
}
[Test]
public void Should_Take_In_Account_Field_References()
{
var definition = AssemblyDefinition.ReadAssembly(@"testdata\external\Spring.Core.dll", new ReaderParameters { AssemblyResolver = AssemblyResolver.Resolver });
var clientType = definition.MainModule.GetType("Spring.Collections.Generic", "ReadOnlyDictionary`2");
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(clientType);
Assert.AreEqual(12, blocks.Count);
}
[Test]
public void Should_Ignore_Empty_Virtual_Methods()
{
var definition = AssemblyDefinition.ReadAssembly(@"testdata\external\Spring.Core.dll", new ReaderParameters { AssemblyResolver = AssemblyResolver.Resolver });
var clientType = definition.MainModule.GetType("Spring.Expressions.Parser.antlr.debug", "ParserListenerBase");
var analyzer = new Lcom4Analyzer();
var blocks = analyzer.FindLcomBlocks(clientType);
Assert.AreEqual(0, blocks.Count);
}
[Test]
public void Should_Take_In_Account_The_Ignorable_Field_Names()
{
var analyzer = new Lcom4Analyzer() { IgnorableFieldNames = new string[] {"Counter"} } ;
var blocks = analyzer.FindLcomBlocks(GetType("DependencyParser.Test.SimpleClass"));
Assert.AreEqual(2, blocks.Count);
}
private TypeDefinition GetType(string name)
{
string unit = Assembly.GetExecutingAssembly().Location;
var assembly = AssemblyDefinition.ReadAssembly(unit);
return assembly.MainModule.GetType(name);
}
}
public class EmptyClass
{
}
public interface IEmpty {
}
public class SimpleClass
{
private int counter;
public void Increment()
{
counter++;
}
public void Decrement()
{
counter--;
}
}
public class SimpleCalculator {
public int Add(int x, int y)
{
return x + y;
}
public int Sub(int x, int y)
{
return x - y;
}
}
public class SimpleClassWithCtr {
private int fieldA;
private int fieldB;
public SimpleClassWithCtr()
{
fieldA = 42;
fieldB = 36;
}
public void doA()
{
fieldA++;
}
public void doB()
{
fieldB++;
}
}
public class ClassWithManyMethodsAndStrongCohesion {
public void doA()
{
Foo();
}
public void doB()
{
Foo();
Bar();
}
public void doC()
{
Bar();
}
private void Foo()
{
Console.WriteLine("Whatever".ToLower());
}
private void Bar()
{
Console.WriteLine("Whatever");
}
}
public class ClassWithProperties {
public int Counter { get; set; }
public string Name { get; set; }
}
public class ClassWithCallsToAccessors {
public int Counter { get; set; }
public string Name { get; set; }
public void Foo()
{
Console.WriteLine("Whatever " + Counter + " " + Name);
}
public void Bar()
{
Console.WriteLine("Whatever " + Counter + " " + Name);
}
}
public class ClassWithComplexProperties {
private int counter;
public int Counter
{
get
{
if (counter>10)
{
return 10;
}
return counter;
}
set
{
counter = value;
}
}
public void Foo()
{
Console.WriteLine("Whatever".ToLower());
}
}
public abstract class AbstractClass {
public void DoA()
{
Foo();
}
public void DoB()
{
Foo();
}
public abstract void DoC();
private void Foo()
{
Console.WriteLine("Whatever".ToLower());
}
}
public abstract class AbstractTemplateClass {
public void DoA()
{
DoC();
}
public void DoB()
{
DoC();
}
public abstract void DoC();
}
public class ClassWithEmptyMethods {
public void Foo()
{
}
public void Bar()
{
}
public virtual void VirBar()
{
}
}
public class ClassWithCallsToEmptyMethods {
public void Foo()
{
VirBar();
}
public void Bar()
{
VirBar();
}
public virtual void VirBar()
{
}
}
public class SimpleDisposableClass : IDisposable
{
public void DoSomething()
{
Console.WriteLine("Whatever");
}
public void Dispose()
{
throw new NotImplementedException();
}
}
public class SimpleClassWithEquals {
private int fieldA;
private int fieldB;
public void DoA()
{
fieldA++;
}
public void DoB()
{
fieldB++;
}
public bool Equals(SimpleClassWithEquals other)
{
if (ReferenceEquals(null, other)) return false;
if (ReferenceEquals(this, other)) return true;
return other.fieldA == fieldA && other.fieldB == fieldB;
}
public override bool Equals(object obj)
{
if (ReferenceEquals(null, obj)) return false;
if (ReferenceEquals(this, obj)) return true;
if (obj.GetType() != typeof (SimpleClassWithEquals)) return false;
return Equals((SimpleClassWithEquals) obj);
}
public override int GetHashCode()
{
unchecked
{
return (fieldA*397) ^ fieldB;
}
}
public static bool operator ==(SimpleClassWithEquals left, SimpleClassWithEquals right)
{
return Equals(left, right);
}
public static bool operator !=(SimpleClassWithEquals left, SimpleClassWithEquals right)
{
return !Equals(left, right);
}
}
public class SimpleClassWithToString {
private int fieldA;
private int fieldB;
public void doA()
{
fieldA++;
}
public void doB()
{
fieldB++;
}
public override string ToString()
{
return fieldA + " " + fieldB;
}
}
public class SimpleClassWithDelegation {
private SimpleClassWithToString wrapped = new SimpleClassWithToString();
public void doA()
{
wrapped.doA();
}
public void doB()
{
wrapped.doB();
}
}
public class DerivedClass : SimpleClassWithTwoFields {
public void doC()
{
doA();
}
public void doD()
{
doA();
doA();
}
}
public class SimpleClassWithStaticMethod {
private int counter;
public void Increment()
{
counter++;
}
public void Decrement()
{
counter--;
}
public static SimpleClassWithStaticMethod create()
{
Console.WriteLine("factory method");
return new SimpleClassWithStaticMethod();
}
}
public abstract class ClassWithExternalCalls {
/// <summary>
/// Inner storage for ReadOnlyDictionary
/// </summary>
private readonly Thread _thread;
public ClassWithExternalCalls(Thread thread)
{
thread = _thread;
}
public void Stop()
{
_thread.Abort();
}
public void Start()
{
_thread.Start();
}
}
}