Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are missing their last line on iOS7 #113

Closed
simonista opened this issue Sep 19, 2013 · 10 comments
Closed

Comments are missing their last line on iOS7 #113

simonista opened this issue Sep 19, 2013 · 10 comments

Comments

@simonista
Copy link

Something weird must be happening with the way comment height gets calculated.

@newsyc
Copy link
Contributor

newsyc commented Sep 21, 2013

Yep, thanks for reporting. I'll look into this along with the rest of the
iOS 7 work.

Grant

Sent from my iPhone

On Sep 19, 2013, at 4:34 PM, Simon Williams notifications@github.com
wrote:

Something weird must be happening with the way comment height gets
calculated.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/113
.

@simonista
Copy link
Author

Cool, thanks! Has that work already started, or is there a list of things that need to be done? I was thinking of cracking this open and seeing if I could get you a pull request.

@PanMan
Copy link

PanMan commented Sep 23, 2013

It's not the only issue: Many comments show up blank on iOS7. Do you have the same issue, or does a screenshot help?

@newsyc
Copy link
Contributor

newsyc commented Sep 23, 2013

I know of the issues — I'm hoping to work on iOS 7 soon.

Sent from my iPhone

On Sep 23, 2013, at 10:40 AM, PanManAms notifications@github.com wrote:

It's not the only issue: Many comments show up blank on iOS7. Do you have
the same issue, or does a screenshot help?


Reply to this email directly or view it on
GitHubhttps://github.com//issues/113#issuecomment-24938257
.

@PanMan
Copy link

PanMan commented Sep 23, 2013

Thanks, let me know if I can help. News:YC is one of the most used apps on my iPad (in my tray), but is fairly broken now :(. Thanks!

@dhruvbhatia
Copy link

@Xuzz Any luck with this?

@grp
Copy link
Owner

grp commented Nov 20, 2013

I'm still working on an update. Hopefully will be ready to submit in the next week.

@mattytrentini
Copy link

Anything I can do to help? news:yc is one of my favourite apps but this issue has been driving me nuts :)

@guiambros
Copy link

@mattytrentini: it was already fixed in the latest branch. It was also driving me nuts, so I compiled it myself and installed last week; huge improvement. It also fixed the issue #109 with Instapaper (among other things), so now you can bookmark articles to read later again.

The only thing is this wasn't pushed to the AppStore yet. @grpaul mentioned somewhere it'd be published together with other iOS7 enhancements (which are now done), so I'd guess this should be soon. In the meantime, if you're a registered iOS developer, just compile and install it; it takes 5 minutes.

@grp
Copy link
Owner

grp commented Dec 14, 2013

This is now fixed in master, and submitted to the App Store. Closing out.

@grp grp closed this as completed Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants