Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Logging Interceptor defaults behave incorrectly #36

Closed
dackroyd opened this issue May 2, 2017 · 2 comments
Closed

Client Logging Interceptor defaults behave incorrectly #36

dackroyd opened this issue May 2, 2017 · 2 comments

Comments

@dackroyd
Copy link
Contributor

dackroyd commented May 2, 2017

The client variants of the logging interceptors were added in #33. Following this change, logging interceptors do not behave correctly in their default configurations i.e. without specifying Options as overrides

Logrus (server & client interceptors):

Unless WithLevels(...) is specified as an option, calls to the logging interceptor panic, as o.levelFunc is nil

Zap (client interceptor only):

Unless WithLevels(...) is specified as an option, calls to the logging interceptor are logged at the incorrect levels as the default is the DefaultCodeToLevel for both server and client interceptors

@mwitkow
Copy link
Member

mwitkow commented May 2, 2017

That was affecting master since #33 until #35. Now it's fixed, and the tests of #35 check the defaults.

Sorry about that.

@dackroyd
Copy link
Contributor Author

dackroyd commented May 2, 2017

Defaults look good again after #35 was merged, thank you!

@mwitkow mwitkow closed this as completed May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants