Add Client interceptors for logging: logrus and zap #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 74.43% 72.95% -1.49%
==========================================
Files 30 32 +2
Lines 884 1050 +166
==========================================
+ Hits 658 766 +108
- Misses 185 241 +56
- Partials 41 43 +2
Continue to review full report at Codecov.
|
dackroyd
reviewed
May 1, 2017
| @@ -94,7 +95,7 @@ func (s *logrusServerSuite) TestPingError_WithCustomLevels() { | |||
| { | |||
| code: codes.Unauthenticated, | |||
| level: logrus.ErrorLevel, | |||
| msg: "Unauthenticated is overwritten to ErrorLevel with customCodeToLevel override, which probably didn't work", | |||
| msg: "Unauthenticated is overwritten to ErrorLevel with customClientCodeToLevel override, which probably didn't work", | |||
There was a problem hiding this comment.
Should this read customCodeToLevel (as it did before) since this is a server interceptor test?
mwitkow
force-pushed
the
feature/client_logging
branch
from
36f54d5
to
e55adc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds simple client-side interceptors for logging. For client side, the default mapping mostly consists of debug-level mapping.
Changes in general:
client_interceptor.goto both logrus and zap, with fairly similar and simple semanticsclient_interceptor_test.goto both logrus and zap, with very similar tests to the server sidespan.kind: server/clientto both logrus and zap server and client-side interceptors to be able to differentiate the log statements.@dackroyd @yifanzz