Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for klog as logging middleware #473

Closed
alok87 opened this issue Nov 20, 2021 · 3 comments
Closed

Support for klog as logging middleware #473

alok87 opened this issue Nov 20, 2021 · 3 comments

Comments

@alok87
Copy link

alok87 commented Nov 20, 2021

We use github.com/kubernetes/klog extensively in many go projects as the logging library.

Possible to get it in here as a middleware. Would love to add support if it is possible.

@johanbrandhorst
Copy link
Collaborator

Hi, thanks for your issue! We're happy to accept this contribution, but consider making it against the v2 branch as we plan to put new work into that branch exclusively.

@alok87
Copy link
Author

alok87 commented Nov 20, 2021

Hey! Great I can add the support. Can you give some reference PR for it and any help on how to go about it will help me do this quick.

@johanbrandhorst
Copy link
Collaborator

You could check out the zap implementation for inspiration: https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v2/providers/zap/logger.go.

mcdoker18 added a commit to mcdoker18/go-grpc-middleware that referenced this issue Aug 19, 2022
mcdoker18 added a commit to mcdoker18/go-grpc-middleware that referenced this issue Aug 19, 2022
@bwplotka bwplotka added the v2 label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants