Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep for management of packages #101

Merged
merged 2 commits into from Nov 21, 2017
Merged

dep for management of packages #101

merged 2 commits into from Nov 21, 2017

Conversation

domgreen
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #101 into master will decrease coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #101      +/-   ##
=========================================
- Coverage   76.49%   75.3%   -1.19%     
=========================================
  Files          34      34              
  Lines        1251    1454     +203     
=========================================
+ Hits          957    1095     +138     
- Misses        245     310      +65     
  Partials       49      49
Impacted Files Coverage Δ
util/metautils/single_key.go 42.85% <0%> (-7.15%) ⬇️
tracing/opentracing/id_extract.go 70% <0%> (-5%) ⬇️
retry/backoff.go 62.5% <0%> (-4.17%) ⬇️
logging/logrus/payload_interceptors.go 80% <0%> (-4.13%) ⬇️
tracing/opentracing/server_interceptors.go 75% <0%> (-4.07%) ⬇️
tracing/opentracing/client_interceptors.go 70.23% <0%> (-4.05%) ⬇️
logging/zap/payload_interceptors.go 80.76% <0%> (-3.85%) ⬇️
retry/retry.go 69.34% <0%> (-3.55%) ⬇️
util/metautils/nicemd.go 88.23% <0%> (-3.44%) ⬇️
tracing/opentracing/options.go 61.11% <0%> (-3.18%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8fef8...e17ffff. Read the comment docs.

@domgreen
Copy link
Contributor Author

i signed it!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@domgreen
Copy link
Contributor Author

again

@yifanzz yifanzz merged commit ab28732 into grpc-ecosystem:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants