Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang.org/x/net/context => context #201

Merged
merged 1 commit into from
Jul 23, 2019
Merged

golang.org/x/net/context => context #201

merged 1 commit into from
Jul 23, 2019

Conversation

houz42
Copy link
Contributor

@houz42 houz42 commented Mar 20, 2019

Update to be used with newest grpc
see #175

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@houz42
Copy link
Contributor Author

houz42 commented Mar 20, 2019

I signed it!

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files          36       36           
  Lines        1349     1349           
=======================================
  Hits          986      986           
  Misses        314      314           
  Partials       49       49
Impacted Files Coverage Δ
wrappers.go 100% <ø> (ø) ⬆️
retry/retry.go 76.11% <ø> (ø) ⬆️
logging/logrus/payload_interceptors.go 84.12% <ø> (ø) ⬆️
logging/logrus/ctxlogrus/context.go 0% <ø> (ø) ⬆️
recovery/options.go 78.57% <ø> (ø) ⬆️
util/metautils/nicemd.go 91.66% <ø> (ø) ⬆️
logging/logrus/server_interceptors.go 92.1% <ø> (ø) ⬆️
logging/zap/server_interceptors.go 100% <ø> (ø) ⬆️
logging/zap/context.go 0% <ø> (ø) ⬆️
validator/validator.go 88.23% <ø> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfaf568...dae89de. Read the comment docs.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@fho
Copy link

fho commented Jul 22, 2019

@kush-patel-hs could this be merged?

@kush-patel-hs
Copy link
Contributor

hey @fho, I am not a maintainer of this project :) would have to reach out to @domgreen and @devnev for review/merge

Copy link
Collaborator

@devnev devnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devnev devnev merged commit e0797f4 into grpc-ecosystem:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants