Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from dep to modules #226

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Move from dep to modules #226

merged 2 commits into from
Aug 28, 2019

Conversation

domgreen
Copy link
Contributor

Adding support for go modules.

The main concern here should be that we do not want to break backwards compatibility with people that are currently using the project. After thinking and discussing it with a few we think that this should be fine as it is. Anyone currently using the project should be okay as we do not have our vendor code checked in and they would be using their own dependencies in some manner (eg. dep).

cc @johanbrandhorst @bwplotka

@domgreen domgreen self-assigned this Aug 27, 2019
@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   71.55%   71.55%           
=======================================
  Files          37       37           
  Lines        1392     1392           
=======================================
  Hits          996      996           
  Misses        347      347           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b65a3d...c406c3b. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@domgreen
Copy link
Contributor Author

I have tested this locally with an internal repo and results look good.

@devnev @mwitkow waiting on a tick from one of you guys 👍

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@domgreen domgreen merged commit bf2a450 into master Aug 28, 2019
@domgreen domgreen deleted the mod branch August 28, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants