New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved to GH actions; Added lint; Added issue/PR templates. #296
Conversation
9d3ee2c
to
5b83c99
Compare
Let's make sure the CI GH actions runs here |
TODO still GH err: https://github.com/grpc-ecosystem/go-grpc-middleware/actions/runs/119943153 |
Super thank your for awesome quick review, will address this afternoon! (: |
7eb5620
to
a6c363a
Compare
533f0ef
to
945fc83
Compare
Be sure to update the import paths in the examples_test files, both for users and it confuses |
Good point, thanks
… |
635d8ed
to
97f4f5a
Compare
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Lot's of vert / lint issue to go through... |
Should be fine now, PTAL @yashrsharma44 @johanbrandhorst |
Codecov Report
@@ Coverage Diff @@
## v2 #296 +/- ##
==========================================
- Coverage 84.01% 79.35% -4.66%
==========================================
Files 30 30
Lines 932 930 -2
==========================================
- Hits 783 738 -45
- Misses 110 150 +40
- Partials 39 42 +3
Continue to review full report at Codecov.
|
dd7379b
to
c1c1b73
Compare
Close to be finished.. two last standing thigs:
This is super weird cannot detected proto changes or other not formatted files - looks like goimports does not format anything at the end 🤔
Some work to either mock time or increase timeouts ... Will look tomorrow if you want to help feel free to propose PR to this PR @https://github.com/yashrsharma44 I have time off tomorrow kind of. (: |
I feel your pain on the tests... |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Fixed linter detected issues. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Add format-only flag Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> * Modify the require_clean_work_tree function. Taken from - https://github.com/git/git/blob/master/git-sh-setup.sh#L211 Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> Added a git script Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> chmod change Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> changes to git-tree.sh Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> Modified makefile Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> clean up changes Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> * Bump timeout deadline to 100ms Signed-off-by: Yash Sharma <yashrsharma44@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Should be good to go - will work on retry flakinesses in separate PR. @yashrsharma44 @johanbrandhorst (: |
Thanks @bwplotka on working on this PR! I will try to make up for the lost time 🤓 |
Can you cut a new tag on branch v2, perhaps |
I've created a new release: https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0-rc.2 |
Hey @irridia! Can you share how did you correctly install v2 branch? |
Thanks. Would you mind also creating a |
Importing at the Generally I just delete the line from go.mod, and run The same method applies when separately importing the log providers at As an example, from a fresh
Then to get zerolog (for example) importing, manually add this line to
Once you run
And cheat mode is just "add those two lines to your go.mod". ;-) |
Thank you so much @irridia ! This was a pretty cool. I googled a lot to find similar issues, but I didn't get any. But the explanation was really awesome, thanks! Edit : |
Done https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/providers%2Fzerolog%2Fv2.0.0-rc.2. I have only tagged zerolog. |
Thanks!
|
Also pinned Go tools thanks to https://github.com/bwplotka/bingo
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com