Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry dial and connection errors for grpc stream. #308

Merged
merged 1 commit into from Jun 17, 2020

Conversation

kartlee
Copy link
Contributor

@kartlee kartlee commented Jun 16, 2020

Pull request to cherry-pick as per #304

-Karthik

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #308 into v2 will decrease coverage by 0.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #308      +/-   ##
==========================================
- Coverage   84.01%   83.40%   -0.61%     
==========================================
  Files          30       30              
  Lines         932      934       +2     
==========================================
- Hits          783      779       -4     
- Misses        110      116       +6     
  Partials       39       39              
Impacted Files Coverage Δ
interceptors/retry/retry.go 75.40% <0.00%> (-3.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2c2ac...7bcf9ad. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit b99e582 into grpc-ecosystem:v2 Jun 17, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@kartlee
Copy link
Contributor Author

kartlee commented Jun 17, 2020

Thanks for considering the pull request.

-Karthik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants