Upgraded proto related deps: grpc and protobuf; removed gogo from core. #321

bwplotka · 2020-07-24T13:38:29Z

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

googlebot · 2020-07-24T13:38:33Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

go.mod

grpctesting/testpb/test.pb.go

bwplotka · 2020-07-24T15:30:53Z

LOL. Next level error messages in generated code via new gRPC protoc-gen-go-grpc: 😄

*TestPingService does not implement testpb.TestServiceServer (missing testpb.mustEmbedUnimplementedTestServiceServer method)

XD

yashrsharma44 · 2020-10-04T05:18:39Z

@googlebot I consent

googlebot · 2020-10-04T05:18:42Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

bwplotka · 2020-12-03T11:38:20Z

Just to remind the goals of this PR:

Update grpc and protobuf deps to latest, use the new API

Given the gogo getting... obsolete (is that right?) maybe we can just stop depending on gogo completely.

johanbrandhorst · 2020-12-03T11:58:30Z

Gogo is indeed unlikely to recover, though Kubernetes just reached out to ask what's going on: https://twitter.com/dims/status/1334219405069258753.

bwplotka · 2021-01-16T19:13:24Z

Ok, getting back to this! (:

cc @yashrsharma44

Let's move this forward. Upgrading both protobuf and grpc to latest

bwplotka · 2021-01-17T10:48:45Z

Should be fine now (:

PTAL @yashrsharma44 @johanbrandhorst

codecov-io · 2021-01-17T11:01:20Z

Codecov Report

Merging #321 (55f20ac) into v2 (a79558a) will decrease coverage by 20.05%.
The diff coverage is 47.16%.

@@             Coverage Diff             @@
##               v2     #321       +/-   ##
===========================================
- Coverage   83.58%   63.52%   -20.06%     
===========================================
  Files          30       34        +4     
  Lines         932      913       -19     
===========================================
- Hits          779      580      -199     
- Misses        114      279      +165     
- Partials       39       54       +15

Impacted Files	Coverage Δ
chain.go	`0.00% <ø> (-90.91%)`	⬇️
grpctesting/interceptor_suite.go	`0.00% <0.00%> (ø)`
grpctesting/pingservice.go	`52.63% <0.00%> (ø)`
interceptors/tags/fieldextractor.go	`13.79% <0.00%> (-71.51%)`	⬇️
interceptors/logging/payload.go	`67.18% <42.30%> (-15.43%)`	⬇️
interceptors/retry/retry.go	`66.66% <70.00%> (-9.58%)`	⬇️
interceptors/skip/interceptor.go	`71.42% <71.42%> (ø)`
interceptors/logging/interceptors.go	`100.00% <100.00%> (ø)`
interceptors/logging/logging.go	`61.53% <100.00%> (-6.21%)`	⬇️
interceptors/ratelimit/ratelimit.go	`100.00% <100.00%> (ø)`
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3d951...582d3a5. Read the comment docs.

interceptors/logging/payload.go

bwplotka · 2021-01-18T18:51:42Z

Makes sense @yashrsharma44, fixed PTAL 🤗

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

bwplotka · 2021-01-20T17:06:18Z

Rebased, PTAL 🤗

yashrsharma44 · 2021-01-20T18:03:09Z

interceptors/logging/payload.go

-		return nil, fmt.Errorf("jsonpb serializer failed: %v", err)
+func logProtoMessageAsJson(logger Logger, pbMsg proto.Message, key string, msg string) {
+	payload, err := protojson.Marshal(pbMsg)
+	if err != nil {


So we can break this rule only for errors 😛 - https://www.bwplotka.dev/2020/how-thanos-would-program-in-go/#control-structure-prefer-early-returns-and-avoid-else

No, we should break it only if it makes sense to do so.

I was thinking about this and since it's only oneliner it does not matter if we do with or without else. WDYT?

I think we could update style guide to mention for multi line bodies? 🤔

yashrsharma44

LGTM 🔥

bwplotka

Thanks @yashrsharma44

Let's wait for @johanbrandhorst review until tomorrow, then we can merge & iterate if something is wrong!

bwplotka · 2021-01-20T19:26:07Z

interceptors/logging/payload.go

-		return nil, fmt.Errorf("jsonpb serializer failed: %v", err)
+func logProtoMessageAsJson(logger Logger, pbMsg proto.Message, key string, msg string) {
+	payload, err := protojson.Marshal(pbMsg)
+	if err != nil {


No, we should break it only if it makes sense to do so.

I was thinking about this and since it's only oneliner it does not matter if we do with or without else. WDYT?

I think we could update style guide to mention for multi line bodies? 🤔

johanbrandhorst

Nice work! Sorry for the delay on the review. I think we should be able to remove gogofast now?

Makefile

go.mod

scripts/genproto.sh

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

bwplotka · 2021-01-22T12:25:06Z

done! @johanbrandhorst

bwplotka commented Jul 24, 2020

View reviewed changes

go.mod Outdated Show resolved Hide resolved

bwplotka force-pushed the update-proto-yash branch 2 times, most recently from d709847 to ed34491 Compare July 24, 2020 14:38

bwplotka commented Jul 24, 2020

View reviewed changes

grpctesting/testpb/test.pb.go Show resolved Hide resolved

bwplotka force-pushed the update-proto-yash branch 3 times, most recently from aafc980 to d16a4d2 Compare July 24, 2020 15:28

bwplotka force-pushed the update-proto-yash branch 2 times, most recently from cb10fb7 to df04530 Compare July 24, 2020 16:18

bwplotka mentioned this pull request Oct 2, 2020

v2: Replace our chaining of interceptors with newest gRPC ones. #342

Closed

bwplotka mentioned this pull request Dec 30, 2020

Allow limiting grpc codes tracked in histrogram grpc-ecosystem/go-grpc-prometheus#96

Open

bwplotka mentioned this pull request Jan 16, 2021

v2 tags: Add tests and examples replacement for gogo.moretags #382

Closed

bwplotka force-pushed the update-proto-yash branch from df04530 to 934ecec Compare January 16, 2021 20:10

bwplotka marked this pull request as ready for review January 16, 2021 20:11

bwplotka force-pushed the update-proto-yash branch from 934ecec to 2809a32 Compare January 16, 2021 20:42

bwplotka requested a review from johanbrandhorst January 16, 2021 21:10

bwplotka force-pushed the update-proto-yash branch from 2809a32 to b5a78c3 Compare January 16, 2021 22:57

bwplotka mentioned this pull request Jan 17, 2021

Moved to buf; Added buf lint; Fixed ping service to match standards; … #383

Merged

bwplotka force-pushed the update-proto-yash branch 4 times, most recently from a4f5db6 to e83983b Compare January 17, 2021 10:48

bwplotka force-pushed the update-proto-yash branch from e83983b to 49fc59c Compare January 17, 2021 10:59

yashrsharma44 reviewed Jan 18, 2021

View reviewed changes

interceptors/logging/payload.go Outdated Show resolved Hide resolved

interceptors/logging/payload.go Outdated Show resolved Hide resolved

interceptors/logging/payload.go Show resolved Hide resolved

interceptors/logging/payload.go Outdated Show resolved Hide resolved

bwplotka force-pushed the update-proto-yash branch from b8cc81b to 55f20ac Compare January 18, 2021 18:52

bwplotka requested a review from yashrsharma44 January 20, 2021 17:02

yashrsharma44 and others added 2 commits January 20, 2021 17:05

Upgraded proto related deps: grpc and protobuf; removed gogo from core.

a719c78

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

Addressed Yash comment.

582d3a5

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

bwplotka force-pushed the update-proto-yash branch from 55f20ac to 582d3a5 Compare January 20, 2021 17:06

yashrsharma44 reviewed Jan 20, 2021

View reviewed changes

yashrsharma44 approved these changes Jan 20, 2021

View reviewed changes

bwplotka commented Jan 20, 2021

View reviewed changes

johanbrandhorst reviewed Jan 21, 2021

View reviewed changes

Makefile Outdated Show resolved Hide resolved

go.mod Outdated Show resolved Hide resolved

scripts/genproto.sh Outdated Show resolved Hide resolved

Addressed Johan comments.

f590c60

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

bwplotka requested a review from johanbrandhorst January 22, 2021 12:25

johanbrandhorst approved these changes Jan 22, 2021

View reviewed changes

bwplotka merged commit c1f1e53 into v2 Jan 22, 2021

bwplotka deleted the update-proto-yash branch January 22, 2021 14:30

aimuz mentioned this pull request Mar 8, 2023

docs: add logging.InjectFields usage description #540

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded proto related deps: grpc and protobuf; removed gogo from core. #321

Upgraded proto related deps: grpc and protobuf; removed gogo from core. #321

bwplotka commented Jul 24, 2020

googlebot commented Jul 24, 2020

bwplotka commented Jul 24, 2020 •

edited

yashrsharma44 commented Oct 4, 2020

googlebot commented Oct 4, 2020

bwplotka commented Dec 3, 2020

johanbrandhorst commented Dec 3, 2020

bwplotka commented Jan 16, 2021

bwplotka commented Jan 17, 2021

codecov-io commented Jan 17, 2021 •

edited

bwplotka commented Jan 18, 2021

bwplotka commented Jan 20, 2021

yashrsharma44 Jan 20, 2021

bwplotka Jan 20, 2021

yashrsharma44 left a comment

bwplotka left a comment

bwplotka Jan 20, 2021

johanbrandhorst left a comment

bwplotka commented Jan 22, 2021

Upgraded proto related deps: grpc and protobuf; removed gogo from core. #321

Upgraded proto related deps: grpc and protobuf; removed gogo from core. #321

Conversation

bwplotka commented Jul 24, 2020

googlebot commented Jul 24, 2020

bwplotka commented Jul 24, 2020 • edited

yashrsharma44 commented Oct 4, 2020

googlebot commented Oct 4, 2020

bwplotka commented Dec 3, 2020

johanbrandhorst commented Dec 3, 2020

bwplotka commented Jan 16, 2021

bwplotka commented Jan 17, 2021

codecov-io commented Jan 17, 2021 • edited

Codecov Report

bwplotka commented Jan 18, 2021

bwplotka commented Jan 20, 2021

yashrsharma44 Jan 20, 2021

Choose a reason for hiding this comment

bwplotka Jan 20, 2021

Choose a reason for hiding this comment

yashrsharma44 left a comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka Jan 20, 2021

Choose a reason for hiding this comment

johanbrandhorst left a comment

Choose a reason for hiding this comment

bwplotka commented Jan 22, 2021

bwplotka commented Jul 24, 2020 •

edited

codecov-io commented Jan 17, 2021 •

edited