Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctxtags TagBasedRequestFieldExtractor extracting from fields in a oneof #327

Merged
merged 1 commit into from Sep 17, 2020

Conversation

nvx
Copy link
Contributor

@nvx nvx commented Aug 28, 2020

Resolves #326

Added a unit test to test the behaviour.

@johanbrandhorst johanbrandhorst merged commit cfd4590 into grpc-ecosystem:master Sep 17, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution, sorry it took a while. Could you cherry pick this against v2 please?

nvx added a commit to nvx/go-grpc-middleware that referenced this pull request Sep 17, 2020
johanbrandhorst pushed a commit that referenced this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctxtags TagBasedRequestFieldExtractor does not extract tags from fields in a oneof
2 participants