Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ratelimit interface context aware #367

Merged
merged 2 commits into from Nov 28, 2020
Merged

make ratelimit interface context aware #367

merged 2 commits into from Nov 28, 2020

Conversation

xinxiao
Copy link
Contributor

@xinxiao xinxiao commented Nov 27, 2020

For #365

@xinxiao xinxiao marked this pull request as draft November 27, 2020 18:40
@xinxiao xinxiao marked this pull request as ready for review November 27, 2020 18:41
@xinxiao xinxiao changed the title make ratelimit interface context aware. make ratelimit interface context aware Nov 28, 2020
johanbrandhorst
johanbrandhorst approved these changes Nov 28, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit 38f54d9 into grpc-ecosystem:v2 Nov 28, 2020
@johanbrandhorst johanbrandhorst mentioned this pull request Nov 28, 2020
Closed
@xinxiao xinxiao deleted the v2 branch November 28, 2020 18:06
@aimuz aimuz mentioned this pull request Mar 8, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xinxiao @johanbrandhorst