New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: validator support for protoc-gen-validate 0.6.0 #418
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## v2 #418 +/- ##
===========================================
- Coverage 83.58% 55.55% -28.03%
===========================================
Files 30 38 +8
Lines 932 1341 +409
===========================================
- Hits 779 745 -34
- Misses 114 524 +410
- Partials 39 72 +33
Continue to review full report at Codecov.
|
d9c094d
to
c3a316b
Compare
Kicking tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! |
Ports #417 to the v2 branch.