Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.18.x and 1.19.x unit tests #513

Merged
merged 1 commit into from Sep 13, 2022

Conversation

aimuz
Copy link
Contributor

@aimuz aimuz commented Sep 8, 2022

Add 1.18.x and 1.19.x unit tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Base: 84.01% // Head: 58.74% // Decreases project coverage by -25.26% ⚠️

Coverage data is based on head (af00985) compared to base (6e2c2ac).
Patch coverage: 50.91% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##               v2     #513       +/-   ##
===========================================
- Coverage   84.01%   58.74%   -25.27%     
===========================================
  Files          30       31        +1     
  Lines         932     1583      +651     
===========================================
+ Hits          783      930      +147     
- Misses        110      590      +480     
- Partials       39       63       +24     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) ⬇️
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/ratelimit/ratelimit.go 60.00% <0.00%> (-40.00%) ⬇️
interceptors/recovery/options.go 78.57% <ø> (ø)
metadata/single_key.go 60.00% <ø> (ø)
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
util/backoffutils/backoff.go 60.00% <ø> (ø)
wrappers.go 66.66% <ø> (-33.34%) ⬇️
interceptors/reporter.go 45.45% <20.00%> (-17.05%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets drop tests for 1.15 and 1.16 while we're at it. Thanks!

Signed-off-by: aimuz <mr.imuz@gmail.com>
@johanbrandhorst johanbrandhorst merged commit cb54482 into grpc-ecosystem:v2 Sep 13, 2022
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants